[U-Boot] [PATCHv1 12/14] usb: ehci/ohci: remove reset_free function

Dinh Nguyen dinguyen at kernel.org
Sat Apr 14 18:51:38 UTC 2018


The call to free the reset control line is a deadend call that doesn't
lead to any reset control functionality.

Also the reset_free() function will be remove in a subsequent patch, so
remove it here.

Signed-off-by: Dinh Nguyen <dinguyen at kernel.org>
---
 drivers/usb/host/ehci-generic.c | 1 -
 drivers/usb/host/ohci-generic.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/usb/host/ehci-generic.c b/drivers/usb/host/ehci-generic.c
index b012d86..8ed6a27 100644
--- a/drivers/usb/host/ehci-generic.c
+++ b/drivers/usb/host/ehci-generic.c
@@ -133,7 +133,6 @@ static int ehci_usb_probe(struct udevice *dev)
 			if (reset_deassert(&priv->resets[i])) {
 				dev_err(dev, "failed to deassert reset %d\n",
 					i);
-				reset_free(&priv->resets[i]);
 				goto reset_err;
 			}
 			priv->reset_count++;
diff --git a/drivers/usb/host/ohci-generic.c b/drivers/usb/host/ohci-generic.c
index 5bdd799..f61c0fc 100644
--- a/drivers/usb/host/ohci-generic.c
+++ b/drivers/usb/host/ohci-generic.c
@@ -125,7 +125,6 @@ static int ohci_usb_probe(struct udevice *dev)
 			err = reset_deassert(&priv->resets[i]);
 			if (err) {
 				dev_err(dev, "failed to deassert reset %d\n", i);
-				reset_free(&priv->resets[i]);
 				goto reset_err;
 			}
 			priv->reset_count++;
-- 
2.7.4



More information about the U-Boot mailing list