[U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Mario Six mario.six at gdsys.cc
Thu Apr 26 08:36:41 UTC 2018


Hi Joakim,

On Thu, Apr 26, 2018 at 10:23 AM, Joakim Tjernlund
<Joakim.Tjernlund at infinera.com> wrote:
> On Thu, 2018-04-26 at 11:35 +0530, Jagan Teki wrote:
>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
>>
>>
>> On Thu, Apr 26, 2018 at 11:24 AM, Mario Six <mario.six at gdsys.cc> wrote:
>> > Hi Jagan,
>> >
>> > On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki <jagannadh.teki at gmail.com> wrote:
>> > > On Thu, Apr 19, 2018 at 6:06 PM, Mario Six <mario.six at gdsys.cc> wrote:
>> > > > This is v2 of a patch series that adds support for DM to the MPC8XXX SPI
>> > > > driver, cleans up the driver code, fixes a few minor problems.
>> > > >
>> > > > Some TODOs are left over for later, such as proper SPI speed setting,
>> > > > and support for SPI mode setting. These would be enhancements to the
>> > > > original functionality, and can come later.
>> > > >
>> > > > The legacy functionality is removed in this version, so old boards in
>> > > > the tree might end up with broken SPI functionality.
>> > > >
>> > > > Mario Six (18):
>> > > >   spi: mpc8xxx: Use short type names
>> > > >   spi: mpc8xxx: Fix comments
>> > > >   spi: mpc8xxx: Rename camel-case variables
>> > > >   spi: mpc8xxx: Fix space after cast
>> > > >   spi: mpc8xxx: Fix function names in strings
>> > > >   spi: mpc8xxx: Replace defines with enums
>> > > >   spi: mpc8xxx: Use IO accessors
>> > > >   spi: mpc8xxx: Simplify if
>> > > >   spi: mpc8xxx: Get rid of is_read
>> > > >   spi: mpc8xxx: Simplify logic a bit
>> > > >   spi: mpc8xxx: Reduce scope of loop variables
>> > > >   spi: mpc8xxx: Make code more readable
>> > > >   spi: mpc8xxx: Rename variable
>> > > >   spi: mpc8xxx: Document LEN setting better
>> > > >   spi: mpc8xxx: Re-order transfer setup
>> > > >   spi: mpc8xxx: Fix if check
>> > > >   spi: mpc8xxx: Use get_timer
>> > > >   spi: mpc8xxx: Convert to DM
>> > >
>> > > Boards with
>> > > - configs/MPC8349EMDS_defconfig
>> > > - configs/ids8313_defconfig
>> > >
>> > > are using this driver, so Kim, Heiko please convert enable DM_SPI for the same.
>> > >
>> > > Use below tree for respective changes and update on top of this.
>> > > http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/next
>> > >
>> >
>> > I have a few series in the making that will enable DM on the MPC83xx platform
>> > (I'm doing a respin on the first right now). If there is still interests in the
>> > boards, I could push it to the MPC83xx repository (but mind that the work
>> > required per board is quite extensive).
>> >
>> > Also, MPC8349EMDS is de facto abandoned, and I don't have access to the
>> > hardware, so I can't really maintain it.
>>
>> It's up to you, look like this board maintained by Kim is not
>> available with freescale e-mail (or may be changed) if none can't
>> maintain, it better to drop the board.
>
> we use custom 832x boards so please don't remove 83xx from u-boot.
>

I'm not planning to do that; on the contrary: I'm trying to update the platform
to fully support DM (I hope to get a fully converted board in after the next
release).

The problem is that we only use MPC8308 SoCs, so I can only vouche for the
correctness of that specific SoC. Everything else is a bit up in the air, since
I'm changing code blindly pretty much.

Best regards,
Mario


More information about the U-Boot mailing list