[U-Boot] [PATCH 2/3] scsi: ceva: add ls1043a soc support

[Peng Ma]

-----Original Message-----
From: York Sun 
Sent: 2018年8月1日 1:38
To: Peng Ma <peng.ma at nxp.com>
Cc: albert.u.boot at aribaud.net; Mingkai Hu <mingkai.hu at nxp.com>; Pankaj Bansal <pankaj.bansal at nxp.com>; Fabio Estevam <fabio.estevam at nxp.com>; Yinbo Zhu <yinbo.zhu at nxp.com>; sjg at chromium.org; bmeng.cn at gmail.com; michal.simek at xilinx.com; Andy Tang <andy.tang at nxp.com>; u-boot at lists.denx.de
Subject: Re: [PATCH 2/3] scsi: ceva: add ls1043a soc support

On 07/09/2018 03:42 AM, peng.ma at nxp.com wrote:
> From: Peng Ma <peng.ma at nxp.com>
> 
> Add ahci compatible support for ls1043a soc.
> 
> Signed-off-by: Peng Ma <peng.ma at nxp.com>
> ---
> depend on:
> 	patchwork.ozlabs.org/patch/924896/
> 
>  drivers/ata/sata_ceva.c |   16 +++++++++-------
>  1 files changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/ata/sata_ceva.c b/drivers/ata/sata_ceva.c index 
> 4c9ebe4..39269fe 100644
> --- a/drivers/ata/sata_ceva.c
> +++ b/drivers/ata/sata_ceva.c
> @@ -7,7 +7,6 @@
>  #include <dm.h>
>  #include <ahci.h>
>  #include <scsi.h>
> -#include <asm/arch/hardware.h>
>  
>  #include <asm/io.h>
>  
> @@ -90,6 +89,7 @@
>  enum ceva_soc {
>  	CEVA_1V84,
>  	CEVA_LS1012A,
> +	CEVA_LS1043A,
>  };
>  
>  struct ceva_sata_priv {
> @@ -98,6 +98,13 @@ struct ceva_sata_priv {
>  	ulong flag;
>  };
>  
> +static const struct udevice_id sata_ceva_ids[] = {
> +	{ .compatible = "ceva,ahci-1v84", .data = CEVA_1V84 },
> +	{ .compatible = "fsl,ls1012a-ahci", .data = CEVA_LS1012A },
> +	{ .compatible = "fsl,ls1043a-ahci", .data = CEVA_LS1043A },
> +	{ }
> +};
> +
>  static int ceva_init_sata(struct ceva_sata_priv *priv)  {
>  	ulong base = priv->base;
> @@ -116,6 +123,7 @@ static int ceva_init_sata(struct ceva_sata_priv *priv)
>  		break;
>  
>  	case CEVA_LS1012A:
> +	case CEVA_LS1043A:
>  		writel(ECC_DIS_ADDR_CH2, ECC_DIS_VAL_CH2);
>  		writel(CEVA_PHY1_CFG, base + AHCI_VEND_PPCFG);
>  		writel(CEVA_TRANS_CFG, base + AHCI_VEND_PTC); @@ -143,12 +151,6 @@ 
> static int sata_ceva_probe(struct udevice *dev)
>  	return ahci_probe_scsi(dev, priv->base);  }
>  
> -static const struct udevice_id sata_ceva_ids[] = {
> -	{ .compatible = "ceva,ahci-1v84", .data = CEVA_1V84 },
> -	{ .compatible = "fsl,ls1012a-ahci", .data = CEVA_LS1012A },
> -	{ }
> -};
> -

Why do you move this structure?

York

Replay: 
In our internal review, you suggested to me that compatible should put before,  so I did that.

Best regards
Peng Ma.