[U-Boot] [PATCH 1/8] arm: K3: Add initial support for TI's K3 generation of SoCs

Lokesh Vutla lokeshvutla at ti.com
Fri Aug 24 14:51:19 UTC 2018



On Friday 24 August 2018 07:40 PM, Tom Rini wrote:
> On Tue, Aug 21, 2018 at 08:00:48PM +0530, Lokesh Vutla wrote:
> 
>> Add support for Texas Instruments' K3 Generation Processor
>> families.
> [snip]
>> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
>> index 9c80090aa7..f48d82f051 100644
>> --- a/drivers/serial/ns16550.c
>> +++ b/drivers/serial/ns16550.c
>> @@ -175,7 +175,7 @@ void NS16550_init(NS16550_t com_port, int baud_divisor)
>>  		;
>>  
>>  	serial_out(CONFIG_SYS_NS16550_IER, &com_port->ier);
>> -#if defined(CONFIG_ARCH_OMAP2PLUS)
>> +#if defined(CONFIG_ARCH_OMAP2PLUS) || defined(CONFIG_ARCH_K3)
>>  	serial_out(0x7, &com_port->mdr1);	/* mode select reset TL16C750*/
>>  #endif
>>  
>> @@ -183,7 +183,8 @@ void NS16550_init(NS16550_t com_port, int baud_divisor)
>>  	serial_out(ns16550_getfcr(com_port), &com_port->fcr);
>>  	if (baud_divisor != -1)
>>  		NS16550_setbrg(com_port, baud_divisor);
>> -#if defined(CONFIG_ARCH_OMAP2PLUS) || defined(CONFIG_SOC_DA8XX)
>> +#if defined(CONFIG_ARCH_OMAP2PLUS) || defined(CONFIG_SOC_DA8XX) || \
>> +	defined(CONFIG_ARCH_K3)
>>  	/* /16 is proper to hit 115200 with 48MHz */
>>  	serial_out(0, &com_port->mdr1);
>>  #endif
> 
> K3 would also be using CONFIG_OMAP_SERIAL once
> https://patchwork.ozlabs.org/patch/956252/ is applied (which I'll do in
> the next release) yes?  I think 956252 needs a follow-up that changes
> the above hunks to be testing off CONFIG_OMAP_SERIAL instead so this

I did not make this change because ns16550 is also used by non-DM
platforms. Since OMAP_SERIAL is DM specific, converting  this #ifdef to
OMAP_SERIAL would break non DM platforms. I guess I should still add ||
OMAP_SERIAL. Ill post a v2 for 956252.

Thanks and regards,
Lokesh


More information about the U-Boot mailing list