[U-Boot] [PATCH 0/7] Remove defines for SPI default speed and mode

[Adam Ford]

On Mon, Dec 10, 2018 at 4:54 AM Patrick Delaunay
<patrick.delaunay at st.com> wrote:
>
>
> This patch-set finish (after the last Simmon comment)
> and depends on the previous serie named:
> "Read default speed and mode values from DT"
>
> http://patchwork.ozlabs.org/project/uboot/list/?series=76834
>
> This patchset remove the unnecessary defines for SPI speed and mode
> when DM mode is used for SPI (CONFIG_DM_SPI_FLASH).
>
> Build result is available for the serie in gihub and travis:
> https://github.com/patrickdelaunay/u-boot/tree/topic/spi
> https://travis-ci.org/patrickdelaunay/u-boot/branches
>
>
After applying both of your patches, the da850evm no longer boots from
SPI flash.

U-Boot SPL 2019.01-rc1-00754-g21fb8c41b1 (Dec 10 2018 - 09:02:28 -0600)
Trying to boot from SPI
Warning: SPI speed fallback to 100 kHz

[repeat in perpetuity]

U-Boot SPL 2019.01-rc1-00754-g21fb8c41b1 (Dec 10 2018 - 09:02:28 -0600)
Trying to boot from SPI
Warning: SPI speed fallback to 100 kHz

I then tried to apply the first patch, and it also fails booting.

I'll reply to the original series with a similar message.  Looking at
the comments, it looks like the code is assuming the DM_SPI_FLASH
means DT when in reality, the da850evm's SPL is using platdata.  I
looked at the platdata structure and I didn't see entries for SPI mode
or speed.  However, I cannot prove this is the issue on the da850evm
without diving into it a bit more.

adam
>
> Patrick Delaunay (7):
>   spi: update management of default speed and mode
>   spi: add comment for spi_flash_probe_bus_cs function
>   da850evm: sf: Read default speed and mode values from DT
>   dfu: sf: Read default speed and mode values from DT
>   mips: mt76xx: gardena-smart-gateway: Read default speed and mode
>     values from DT
>   env: Read default speed and mode values from DT
>   spi: remove define for SPI default SPEED and MODE
>
>  board/davinci/da8xxevm/da850evm.c          |  7 +++++++
>  board/gardena/smart-gateway-mt7688/board.c | 24 ++++++++++++++++++++----
>  cmd/sf.c                                   | 10 ++++++----
>  common/spl/spl_spi.c                       | 11 ++++++-----
>  common/splash_source.c                     | 11 ++++++-----
>  drivers/dfu/dfu_sf.c                       | 10 ++++++++--
>  env/Kconfig                                |  4 ++--
>  env/sf.c                                   |  5 ++++-
>  include/spi_flash.h                        | 18 ++++++++++++++++++
>  9 files changed, 77 insertions(+), 23 deletions(-)
>
> --
> 2.7.4
>