[U-Boot] [PATCH v2 0/2] Read default speed and mode values from DT

[Patrick DELAUNAY]

Hi Adam,

> -----Original Message-----
> From: Adam Ford <aford173 at gmail.com>
> Sent: lundi 10 décembre 2018 16:50
> 
> On Mon, Nov 19, 2018 at 12:01 PM Patrick Delaunay
> <patrick.delaunay at st.com> wrote:
> >
> >
> > This serie generalize the commit 96907c0fe50a
> > ("dm: spi: Read default speed and mode values from DT")
> >
> > In case of DT boot, don't read default speed and mode for SPI from
> > CONFIG_*, instead read from DT node. This will make sure that boards
> > with multiple SPI/QSPI controllers can be probed at different bus
> > frequencies and SPI modes.
> >
> > Today it is only done in the command sf; this patch do the same for
> > the other user of the spi_flash_probe(): spl and splash to avoid probe
> > issue.
> >
> >
> > Changes in v2:
> > - use variables to avoid duplicated code
> > - use variables to avoid duplicated code
> >
> > Patrick Delaunay (2):
> >   spl_spi: Read default speed and mode values from DT
> >   splash: sf: Read default speed and mode values from DT
> >
> >  common/spl/spl_spi.c   | 10 ++++++++--
> >  common/splash_source.c | 12 ++++++++++--
> >  2 files changed, 18 insertions(+), 4 deletions(-)
> >
> 
> I replied to another thread, but to prevent a hasty decision, I thought I'd
> mention that this patch series breaks the da850evm.
> 
> U-Boot SPL 2019.01-rc1-00747-g1a3453efed (Dec 10 2018 - 09:07:08 -0600)
> Trying to boot from SPI
> Warning: SPI speed fallback to 100 kHz
> 
> (And repeat the above forever)
> 
> I know Jagan just re-did some of the da850 SPI driver and I wonder if the
> updated driver just needs mode and speed entries added to platdata then
> extracted from platdata when the driver is initialized.
> 
> adam

Thanks for the tests, I agree the serie can't be merged in this state.

I will come back only in 3 weeks....
and I will check this point when I will come back.
That should avoid many issue as already solved for the 2 series 

http://patchwork.ozlabs.org/patch/1010363/
http://patchwork.ozlabs.org/patch/995030/

That should be avoid revert in the next daysas :
http://git.denx.de/?p=u-boot.git;a=commit;h=25a17652c9c2cc4d88098121fc6a2b8f90020531


NB: for short term solution without patch, 
       for platform with DT only flash description (as my platform stm32mp1), we can use

CONFIG_SF_DEFAULT_SPEED=0
CONFIG_SF_DEFAULT_MODE=0

That should be solved the current issue in my board without need to merge the 2 series (not yet tested).

> > --
> > 2.7.4
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > https://lists.denx.de/listinfo/u-boot