[U-Boot] [U-Boot, v2, 10/15] dm: mmc: sunxi: Add support for driver model

[Heinrich Schuchardt]

On 02/01/2018 04:11 PM, Tuomas Tynkkynen wrote:
> Hi Heinrich,
> 
> On Wed, 2018-01-31 at 18:08 +0100, Heinrich Schuchardt wrote:
>> On 07/04/2017 09:31 PM, Simon Glass wrote:
>>> Add a driver-model version of this driver which mostly uses the
>>> existing
>>> code. The old code can be removed once all boards are switched
>>> over.
>>>
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>> ---
>>>
>>> Changes in v2:
>>> - Drop debugging printf() now that the card detect is working
>>
>> Unfortunately card detect is not working on the BananaPi:
> 
> Most likely it's the problem of U-Boot interpreting the card detection
> DT properties differently from Linux. See this thread for details:
> 
> https://patchwork.ozlabs.org/patch/850377/
> 

Thanks for your analysis

arch/arm/dts/sun7i-a20-bananapi.dts
has 'cd-inverted' for MMC0.

The string 'cd-inverted' does not exist in drivers/mmc/sunxi_mmc.c.

sunxi_mmc_getcd():
return dm_gpio_get_value(&priv->cd_gpio);

sunxi_mmc_getcd_legacy():
return !gpio_get_value(cd_pin); /* Observe the NOT here */

I will keep you informed.

Regards

Heinrich