[U-Boot] [PATCH v3 0/4] arm: imx53: remove usage of mx53_dram_size

[Stefano Babic]

Hi Patrick,

On 16/01/2018 07:59, linux-kernel-dev at beckhoff.com wrote:
> From: Patrick Bruenn <p.bruenn at beckhoff.com>
> 
> Global variables are not available during board_init_f().
> The i.MX53 boards m53evk, mx53cx9020 and mx53loco are using the exact
> same dram initialization code, which uses
> 'static uint32_t mx53_dram_size[2];' in dram_init(),
> dram_init_banksize() and get_effective_memsize() to avoid multiple
> calls to get_ram_size().
> 
> This series replaces the static variable with multiple calls to
> get_ram_size() and moves the shared code into arch/arm/mach-imx/mx5/.
> 
> The first patch is required to let cx9020 boot again. Please include at
> least this one. Without that patch u-boot on cx9020 is broken.
> 

I applied this.

> The second patch moves that code to a common place to be reused by
> m53evk and mx53loco. Pick it only if you think this change is useful for
> one of these boards and you are willing to include the third and/or last
> patch.

>From discussion between you and Marek, I understood that mx53evk is fine
with changes. Applied, too.

> Pick the third patch if you want to use the changed code for m53evk.
> Pick the last patch if you want to use the changed code for mx53loco.

And if mx53evk is fine, I prefer that mx53 boards behave in the same
way. I pick up these, too.

Thanks,

Stefano Babic

> 
> 
> Changes in v3:
> - rebase to v2018.01
> - fix the cover-letter to make it more clear that the first patch is
>   required to make the cx9020 boot again. All other patches are
>   optional.
> 
> Changes in v2:
> - move dram initialization into common location
> - reuse fixed dram initialization for m53evk and mx53loco
> 
> Patrick Bruenn (4):
>   arm: imx: cx9020: remove usage of mx53_dram_size
>   arm: imx: cx9020: move dram init into common place
>   arm: imx: m53evk: remove usage of mx53_dram_size
>   arm: imx: mx53loco: remove usage of mx53_dram_size
> 
>  arch/arm/mach-imx/mx5/Makefile         |  5 ++++
>  arch/arm/mach-imx/mx5/mx53_dram.c      | 45 ++++++++++++++++++++++++++++++++++
>  board/aries/m53evk/m53evk.c            | 39 -----------------------------
>  board/beckhoff/mx53cx9020/mx53cx9020.c | 39 -----------------------------
>  board/freescale/mx53loco/mx53loco.c    | 39 -----------------------------
>  5 files changed, 50 insertions(+), 117 deletions(-)
>  create mode 100644 arch/arm/mach-imx/mx5/mx53_dram.c
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================