[U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc

Tom Rini trini at konsulko.com
Mon Feb 12 16:53:09 UTC 2018


On Mon, Feb 12, 2018 at 05:51:08PM +0100, Marek Vasut wrote:
> On 02/12/2018 05:46 PM, Tom Rini wrote:
> > On Mon, Feb 12, 2018 at 03:54:13PM +0100, Marek Vasut wrote:
> >> On 02/12/2018 03:52 PM, Simon Goldschmidt wrote:
> >>> In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some
> >>> thins for spi flash and mmc that are not required by the hw.
> >>
> >> things ?
> >>
> >> what hw, all supported boards you mean ?
> >>
> >>> Give users more freedom of choice and use imply here instead
> >>> of select.
> >>>
> >>> This should allow disabling spi support completely or using
> >>> sd/mmc boot in "raw mode" (no partitions).
> >>
> >> You can just turn them off in the defconfigs, but I get what you're
> >> trying to say.
> > 
> > Well, hold on.  If you have select FOO under ARCH_xxx then you
> > can't disable it.  You have to use imply FOO under ARCH_xxx so that it's
> > turned on by default but a board can disable it in their defconfig.
> > Thanks!
> 
> The patch is using imply already ...

Right.  I wasn't clear if you were saying it wasn't needed, or just to
re-word things a lot :)

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180212/16e74525/attachment.sig>


More information about the U-Boot mailing list