[U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc

Simon Goldschmidt sgoldschmidt at de.pepperl-fuchs.com
Tue Feb 13 12:33:38 UTC 2018


On 12.02.2018 15:54, Marek Vasut wrote:
> On 02/12/2018 03:52 PM, Simon Goldschmidt wrote:
>> In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some
>> thins for spi flash and mmc that are not required by the hw.
> things ?
>
> what hw, all supported boards you mean ?
>
>> Give users more freedom of choice and use imply here instead
>> of select.
>>
>> This should allow disabling spi support completely or using
>> sd/mmc boot in "raw mode" (no partitions).
> You can just turn them off in the defconfigs, but I get what you're
> trying to say.
>
> Just reword the commit message and do make savedefconfig for all the
> socfpga platforms (in a separate patch) to sync the defconfigs up.

I've posted v2 today with reworded commit message. I also did make 
savedefconfig, but nothing changed.

Simon

>
>> Signed-off-by: Simon Goldschmidt <sgoldschmidt at de.pepperl-fuchs.com>
>> ---
>>
>>   arch/arm/Kconfig | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 225f57e847..37bf3dd69f 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -699,13 +699,13 @@ config ARCH_SOCFPGA
>>   	select OF_CONTROL
>>   	select SPL_OF_CONTROL
>>   	select DM
>> -	select DM_SPI_FLASH
>> -	select DM_SPI
>>   	select ENABLE_ARM_SOC_BOOT0_HOOK
>>   	select ARCH_EARLY_INIT_R
>>   	select ARCH_MISC_INIT
>> -	select SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
>>   	select SYS_THUMB_BUILD
>> +	imply DM_SPI_FLASH
>> +	imply DM_SPI
>> +	imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
>>   	imply CMD_MTDPARTS
>>   	imply CRC32_VERIFY
>>   	imply FAT_WRITE
>>
>



More information about the U-Boot mailing list