[U-Boot] [U-Boot, v2] env: mmc/fat/ext4: make sure that the MMC sub-system is initialized before using it

[Wolfgang Denk]

Dear Tom,

In message <20180220220328.GC4311 at bill-the-cat> you wrote:
> 
> > We need to make sure that the MMC sub-system is ready in even a non-MMC
> > boot case.
> > 
> > Therefore, initialize mmc before loading environment from it.
> > 
> > Signed-off-by: Faiz Abbas <faiz_abbas at ti.com>
>
> Applied to u-boot/master, thanks!

I had sent a (gentle) NAK for this patch before (Message-id:
<20180207085212.387EB2406CC at gemini.denx.de> Date: Wed, 07 Feb 2018
09:52:12 +0100).

It is wrong to initialize any sub-system just in case it might be
needed. Quote from my message:

In this case I hereby NAK this patch.

U-Boot shall always use lazy initialization and never ever initialize
hardware which it does not really use - see especially item 2 at
[1].

[1] http://www.denx.de/wiki/U-Boot/DesignPrinciples



Why do you ignore this NAK, and why do you add this patch so late in
the release cycle anyway?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Marriage is like a cage; one sees the birds outside desperate to get
in, and those inside desperate to get out."               - Montaigne