[U-Boot] [U-Boot, v2] env: mmc/fat/ext4: make sure that the MMC sub-system is initialized before using it

[Tom Rini]

On Sat, Feb 24, 2018 at 09:58:45PM +0100, Wolfgang Denk wrote:
> Dear Tom,
> 
> In message <20180220220328.GC4311 at bill-the-cat> you wrote:
> > 
> > > We need to make sure that the MMC sub-system is ready in even a non-MMC
> > > boot case.
> > > 
> > > Therefore, initialize mmc before loading environment from it.
> > > 
> > > Signed-off-by: Faiz Abbas <faiz_abbas at ti.com>
> >
> > Applied to u-boot/master, thanks!
> 
> I had sent a (gentle) NAK for this patch before (Message-id:
> <20180207085212.387EB2406CC at gemini.denx.de> Date: Wed, 07 Feb 2018
> 09:52:12 +0100).
> 
> It is wrong to initialize any sub-system just in case it might be
> needed. Quote from my message:
> 
> In this case I hereby NAK this patch.
> 
> U-Boot shall always use lazy initialization and never ever initialize
> hardware which it does not really use - see especially item 2 at
> [1].
> 
> [1] http://www.denx.de/wiki/U-Boot/DesignPrinciples
> 
> 
> 
> Why do you ignore this NAK, and why do you add this patch so late in
> the release cycle anyway?

Sorry, didn't v2 address your concerns?  We don't initialize the device
because maybe we'll have env there, we initalize mmc because we need to
check that it is there.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180224/23261343/attachment.sig>