[U-Boot] [PATCH V4] Convert CONFIG_SOC_DA8XX et al to Kconfig

Adam Ford aford173 at gmail.com
Tue Jan 2 22:21:02 UTC 2018


On Tue, Jan 2, 2018 at 2:46 PM, David Lechner <david at lechnology.com> wrote:
> On 01/02/2018 02:39 PM, Adam Ford wrote:
>>
>> On Tue, Jan 2, 2018 at 2:25 PM, David Lechner <david at lechnology.com>
>> wrote:
>>>
>>> On 01/02/2018 01:55 PM, Adam Ford wrote:
>>>>
>>>>
>>>> On Tue, Jan 2, 2018 at 1:05 PM, David Lechner <david at lechnology.com>
>>>> wrote:
>>>>>
>>>>>
>>>>> On 01/02/2018 12:45 PM, Adam Ford wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> This converts the following to Kconfig:
>>>>>>       CONFIG_SOC_DA8XX
>>>>>>       CONFIG_SOC_DA850
>>>>>>       CONFIG_DA850_LOWLEVEL
>>>>>>       CONFIG_MACH_DAVINCI_DA850_EVM
>>>>>>       CONFIG_SYS_DA850_PLL_INIT
>>>>>>       CONFIG_SYS_DA850_DDR_INIT
>>>>>>

>>
>
> I didn't dig that deep, so sounds good to me. However, if you are always
> enabling SYS_DA850_PLL_INIT and SYS_DA850_DDR_INIT when da850_low_level.c
> is compiled, then you might as well just remove those options altogether.
> They are not used outside of da850_low_level.c and it would clean up a
> bunch of #ifdefs.

I don't want to make changes to .C source code yet.  At this time, my
goal is to limit it to Kconfig and defconfig files.  I'll clean this
up a bit more and run some tests.  I think I'll make some notes to go
back through it and remove the #ifdef's at a later date.
I want to be able to bisect to this point if something breaks.  Once
I'm confident everyone will be OK with this, I think what you're
saying makes a lot of sense.

adam


More information about the U-Boot mailing list