[U-Boot] [PATCH 03/11] env: add support for whitelisting variables from secondary environments

[Quentin Schulz]

Hi Lukasz,

On 26/12/2017 12:21, Lukasz Majewski wrote:
> Hi Quentin,
> 
>> +config ENV_VAR_WHITELIST
>> +	bool "Enable overriding some variables from secondary
>> environments"
>> +	help
>> +	  This allows overriding some variables from secondary
>> environments.
>> +	  After the first valid environment is loaded, a secondary
>> environment
>> +	  is pre-loaded and its variables that are present in the
>> whitelist will
>> +	  be added to the current environment or will override
>> existing
>> +	  variables.
> 
> This description seems to do what is already done in the "env import"
> command.
> 

Didn't know that one, thanks.

> It also allows for setting env variables from HUSH prompt.
> 
> Maybe it would be possible to re-use or extend it to suits your needs?
> 

It's pretty much everything I needed except the whitelisting of variables.

While it's possible for env export to take a list of variables to
export, for what I've seen, env import does not take a list of variables
to import.

It's needed since the env I'll import is unsafe. I'll have a look at
that and make an other RFC :)

Thanks for the review, very helpful,

Quentin
-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180103/c0b3f77b/attachment.sig>