[U-Boot] [PATCH v2 1/2] video: ipu: Fix dereferencing NULL pointer problem

Anatolij Gustschin agust at denx.de
Wed Jan 3 11:20:49 UTC 2018


From: Peng Fan <peng.fan at nxp.com>

The clk_set_rate function dereferences the clk pointer without
checking whether it is NULL. This may cause problem when clk is NULL.

Signed-off-by: Peng Fan <peng.fan at nxp.com>
Signed-off-by: Anatolij Gustschin <agust at denx.de>
---
Changes in v2:
 - move the NULL check to top of function
 
 drivers/video/ipu_common.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/video/ipu_common.c b/drivers/video/ipu_common.c
index 96229da502..889085aa76 100644
--- a/drivers/video/ipu_common.c
+++ b/drivers/video/ipu_common.c
@@ -132,8 +132,12 @@ struct clk *clk_get_parent(struct clk *clk)
 
 int clk_set_rate(struct clk *clk, unsigned long rate)
 {
-	if (clk && clk->set_rate)
+	if (!clk)
+		return 0;
+
+	if (clk->set_rate)
 		clk->set_rate(clk, rate);
+
 	return clk->rate;
 }
 
-- 
2.11.0



More information about the U-Boot mailing list