[U-Boot] [PATCH v4 0/4] net: phy: Add Broadcom BCM53xx switch driver

Joe Hershberger joe.hershberger at gmail.com
Wed Jan 3 21:43:55 UTC 2018


On Wed, Dec 27, 2017 at 1:55 PM, Florian Fainelli <f.fainelli at gmail.com> wrote:
>
>
> On 12/09/2017 03:02 PM, Joe Hershberger wrote:
>> On Sat, Dec 9, 2017 at 4:59 PM, Florian Fainelli <f.fainelli at gmail.com> wrote:
>>> Hi all,
>>>
>>> This patch series adds support for the Broadcom BCM53xx switches, in particular
>>> BCM53125 which is found no the Lamobo R1 board.
>>>
>>> The driver is largely based on the DSA/b53 driver Linux driver and only
>>> incorporates what is necessary to succesfully bring-up all ports (including the
>>> management port) for boot over the network:
>>>
>>> => dhcp
>>> dw_adjust_link: Speed: 1000, full duplex
>>> BOOTP broadcast 1
>>> DHCP client bound to address 192.168.0.11 (3 ms)
>>> Using ethernet at 01c50000 device
>>> TFTP from server 192.168.0.1; our IP address is 192.168.0.11
>>> Filename 'sun7i-a20-lamobo-r1-kernel.bin'.
>>> Load address: 0x42000000
>>> Loading: #################################################################
>>>          #################################################################
>>>          ################################
>>>          11.6 MiB/s
>>> done
>>> Bytes transferred = 2371552 (242fe0 hex)
>>> =>
>>>
>>> Joe there is one warning left which does not look legit to me since we now have
>>> a help paragraph describing the config symbol:
>>>
>>> WARNING: please write a paragraph that describes the config symbol fully
>>> #34: FILE: drivers/net/phy/Kconfig:15:
>>> +config B53_SWITCH
>>>
>>> and one CHECK left which I intentionally did not fix because it makes the
>>> definitions of the bits less clear:
>>> CHECK: Prefer using the BIT macro
>>> #134: FILE: drivers/net/phy/b53.c:63:
>>> +#define   PORT_OVERRIDE_SPEED_100M     (1 << PORT_OVERRIDE_SPEED_S)
>>
>> Works for me.o
>
> Should I expect you to queue up these patches in a git tree/branch, or
> is someone else picking up networking/PHY patches?

Sorry for the delay - I was out for a few weeks and couldn't get
things in before I left due to people's bad patches breaking build.

Pull request sent today includes this.

Cheers,
-Joe


More information about the U-Boot mailing list