[U-Boot] [PATCH 2/2] rockchip: firefly-rk3399: enable SPL_ATF_NO_PLATFORM_PARAM

Dr. Philipp Tomsich philipp.tomsich at theobroma-systems.com
Thu Jan 4 11:03:48 UTC 2018


Michal,

> On 4 Jan 2018, at 08:56, Michal Simek <monstr at monstr.eu> wrote:
> 
> Hi Kever,
> 
> On 3.1.2018 03:34, Kever Yang wrote:
>> Hi Philipp,
>> 
>> 
>> On 01/03/2018 04:16 AM, Philipp Tomsich wrote:
>>> The Rockchip-released ATF for the Firefly apparently (i.e. Kever
>>> reported this) does not tolerate a FDT being passed as the platform
>>> parameter and will run into a hard stop.
>>> 
>>> To work around this limitation in the ATF parameter handling, we
>>> enable SPL_ATF_NO_PLATFORM_PARAM (which will force passing NULL for
>>> the platform parameters).
>>> 
>>> Note that this only affects this platform, as the ATF releases for the
>>> RK3368 and RK3399 have always either ignored the platform parameter
>>> (i.e. before the FDT-based parameters were supported) or support
>>> receiving a pointer to a FDT.
>> 
>> Upstream ATF of Rockchip platform support a vendor defined
>> " structbl31_plat_param *bl2_param", will add support for FDT later,
>> see params_early_setup() in
>> https://github.com/ARM-software/arm-trusted-firmware/blob/master/plat/rockchip/common/params_setup.c
> What exactly do you want to configure in ATF from FDT?
> Do you have any code somewhere to take a look?

On the RK3399-Q7, we configure both what our sysreset-gpio is and 
signal the location from where the PMU firmware should be relocated
to its final location.

For an older versions of these changes (these are currently being reworked
for upstreaming), see:
	https://git.theobroma-systems.com/arm-trusted-firmware.git/commit/?id=07b6f3535f5abe3a7c00ca0838d1b8d674975228

Regards,
Philipp.

> 
> Thanks,
> Michal
> 
> -- 
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: www.monstr.eu <http://www.monstr.eu/> p: +42-0-721842854
> Maintainer of Linux kernel - Xilinx Microblaze
> Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
> U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs



More information about the U-Boot mailing list