[U-Boot] [PATCH] crypto/fsl: fix BLOB encapsulation and decapsulation

York Sun york.sun at nxp.com
Thu Jan 4 17:14:47 UTC 2018


On 01/04/2018 01:39 AM, Fabio Estevam wrote:
> Hi York,
> 
> On Wed, Jan 3, 2018 at 3:26 PM, Tom Rini <trini at konsulko.com> wrote:
>> On Wed, Jan 03, 2018 at 02:32:44PM -0200, Fabio Estevam wrote:
>>> Hi Tom,
>>>
>>> On Wed, Dec 20, 2017 at 8:08 PM, Clemens Gruber
>>> <clemens.gruber at pqgruber.com> wrote:
>>>> The blob_encap and blob_decap functions were not flushing the dcache
>>>> before passing data to CAAM/DMA and not invalidating the dcache when
>>>> getting data back.
>>>> Therefore, blob encapsulation and decapsulation failed with errors like
>>>> the following due to data cache incoherency:
>>>> "40000006: DECO: desc idx 0: Invalid KEY command"
>>>>
>>>> To ensure coherency, we allocate aligned memory to store the data passed
>>>> to/from CAAM and flush/invalidate the memory regions.
>>>> Blobs can now be encapsulated and decapsulated with the blob cmd as well
>>>> as from board code by calling blob_encap and blob_decap directly.
>>>>
>>>> Tested on an i.MX6Q board.
>>>>
>>>> Signed-off-by: Clemens Gruber <clemens.gruber at pqgruber.com>
>>>
>>> This bug fix patch seems like a good candidate for 2018.01.
>>>
>>> Not sure who can pick it and apply it.
>>>
>>> Tom, York? What do you guys think?
>>
>> I'm fine with it coming in directly or via a PR.
> 
> Could you please help applying this one?
> 

Sorry for late reply. Trying to catch up after my vacation. I have
kicked off compiling tests. Will send a PR if everything is fine.

York


More information about the U-Boot mailing list