[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

[Maxime Ripard]

Hi Andre,

On Thu, Dec 21, 2017 at 02:50:29PM +0000, Andre Przywara wrote:
> Hi,
> 
> On 21/12/17 12:40, Maxime Ripard wrote:
> > The sunXi arm64 build has overflown, leading to the main U-boot binary
> > overwriting the environment when flashing the new image, or even worse,
> > overwriting itself when we're calling saveenv.
> > 
> > Disable this command that is not critical until we can adress the issue
> > properly.
> > 
> > Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> > ---
> >  cmd/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > index c0332235261f..7751001819d0 100644
> > --- a/cmd/Kconfig
> > +++ b/cmd/Kconfig
> > @@ -397,6 +397,7 @@ menu "Memory commands"
> >  config CMD_CRC32
> >  	bool "crc32"
> >  	select HASH
> > +	default n if ARCH_SUNXI
> 
> Is that meant to solve issues with 32 bit boards as well? Or shall we
> use "ARCH_SUNXI && ARM64" here?
> 
> In case including 32-bit is intentional, this is:
> 
> for [PATCH 01/11] - [PATCH 04/11]:
> Reviewed-by: Andre Przywara <andre.przywara at arm.com>

This is intentional. I really want to have an experience as close as
possible on the arm and arm64 boards, and having the same commands set
is one of the things that matter to achieve that :)

> If no one shoot any of those options down, you might want to squash them
> into one patch, since they all go into the same file.

That works for me :)

> Unless you need to meet some company patch count target before the end
> of the year :-D

I guess I missed that deadline already... ;)

> P.S. Shall we mark those patches somehow, so that we can easily revert
> them later? Those commands can be useful.

That might be a good idea. Do you have a suggestion?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180105/b492cb42/attachment.sig>