[U-Boot] [PATCH v3 1/1] vsprintf.c: add EFI device path printing

[Heinrich Schuchardt]

On 01/08/2018 11:11 PM, Simon Glass wrote:
> HI Heinrich,
> 
> On 8 January 2018 at 08:09, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>>
>>
>> On 01/08/2018 04:52 AM, Simon Glass wrote:
>>>
>>> On 26 December 2017 at 03:07, Heinrich Schuchardt <xypron.glpk at gmx.de>
>>> wrote:
>>>>
>>>> For debugging efi_loader we need the capability to print EFI
>>>> device paths. With this patch we can write:
>>>>
>>>>       debug("device path: %pD", dp);
>>>>
>>>> A possible output would be
>>>>
>>>>       device path: /MemoryMapped(0x0,0x3ff93a82,0x3ff93a82)
>>>>
>>>> This enhancement is not available when building without EFI support
>>>> and neither in the SPL nor in the API example.
>>>>
>>>> Cc: Wolfgang Denk <wd at denx.de>
>>>> Cc: Simon Glass <sjg at chromium.org>
>>>> Suggested-by: Rob Clark <robdclark at gmail.com>
>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>>>> ---
>>>> I propose Alex picks up this patch for the EFI tree.
>>>>
>>>> v3:
>>>>           Return -ENOMEM if out of memory.
>>>>           Avoid missing dependency error when building the SPL of the
>>>>           API example.
>>>> v2:
>>>>           Panic if out of memory.
>>>>           Wolfgang suggested not to silently ignore an out of memory
>>>>           situation.
>>>> ---
>>>>    examples/api/Makefile |  3 +++
>>>>    lib/vsprintf.c        | 47
>>>> +++++++++++++++++++++++++++++++++++++++++------
>>>>    2 files changed, 44 insertions(+), 6 deletions(-)
>>>
>>>
>>> Can you please add a test for this? It could go in the print unit
>>> tests, perhaps?
>>>
>>> Regards,
>>> Simon
>>>
>> test/print_ut.c is only compiled with CONFIG_SANDBOX.
>>
>> It seems your patches to enable EFI_LOADER in the sandbox did not make it
>> into v2018.01. Are you still working on these? Do you have a repo with a
>> working copy?
> 
> I was really not sure where to take it. It seemed that most of them
> were ready to apply. I didn't check who they were assigned to.
> 
> Tree is u-boot-dm/efi-working
> 
> I can certainly pick it up again, but I do need to understand what is
> holding it up.
> 
> Regards,
> Simon
> 

The patch series
https://patchwork.ozlabs.org/project/uboot/list/?series=16686
is assigned to Alex.

There are some unanswered review comments.

Best regards

Heinrich