[U-Boot] [PATCH v1 1/2] x86: tangier: Use actual GPIO hardware numbers

Bin Meng bmeng.cn at gmail.com
Tue Jan 9 01:51:34 UTC 2018


On Mon, Jan 8, 2018 at 12:51 PM, Simon Glass <sjg at chromium.org> wrote:
> On 4 January 2018 at 09:40, Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
>> The recent commit 03c4749dd6c7
>>   ("gpio / ACPI: Drop unnecessary ACPI GPIO to Linux GPIO translation")
>> in the Linux kernel reveals the issue we have in ACPI tables here,
>> i.e. we must use hardware numbers for GPIO resources and,
>> taking into consideration that GPIO and pin control are *different* IPs
>> on Intel Tangier, we need to supply numbers properly.
>>
>> Besides that, it improves user experience since the official documentation
>> for Intel Edison board is referring to GPIO hardware numbering scheme.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
>> ---
>>
>> Bin, this is kinda urgent fix. I wouldn't like to have a release with
>> wrong numbering scheme, although there is none users yet, only couple
>> amateurs that are experimenting with the code.
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

applied to u-boot-x86, thanks!


More information about the U-Boot mailing list