[U-Boot] [PATCH 3/7] tools: include necessary headers explicitly

Joe Hershberger joe.hershberger at ni.com
Tue Jan 9 17:23:04 UTC 2018


On Tue, Jan 9, 2018 at 3:34 AM, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> Several host-tools use "bool" type without including <stdbool.h>.
> This relies on the crappy header inclusion chain.
>
> tools/Makefile has the following line:
>
>   HOST_EXTRACFLAGS += -include $(srctree)/include/libfdt_env.h \
>
> All host-tools are forced to include libfdt_env.h even if they are
> totally unrelated to FDT.  Then, <stdbool.h> is indirectly included
> as follows:
>
>      include/libfdt_env.h
>   -> include/linux/types.h
>   -> <stdbool.h>
>
> I am fixing this horrible crap.  In advance, I need to add necessary
> include directives explicitly.  tools/fdtgrep.c needs more; <fctl.h>
> for open() and <errno.h> for errno.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>

Reviewed-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list