[U-Boot] [PATCH 03/07] db410c: replace reset driver with psci

Tuomas Tynkkynen tuomas.tynkkynen at iki.fi
Wed Jan 10 02:27:45 UTC 2018


Hi Jorge,

On 01/09/2018 11:12 AM, Jorge Ramirez-Ortiz wrote:
> From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz at linaro.org>
> 
> this should be the norm for armv8 platforms.
> 
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz at linaro.org>
> ---
>   arch/arm/dts/dragonboard410c.dts                 |  5 ---
>   board/qualcomm/dragonboard410c/dragonboard410c.c |  5 +++
>   configs/dragonboard410c_defconfig                |  2 +-
>   drivers/sysreset/Makefile                        |  2 --
>   drivers/sysreset/sysreset_snapdragon.c           | 40 ------------------------
>   5 files changed, 6 insertions(+), 48 deletions(-)
>   delete mode 100644 drivers/sysreset/sysreset_snapdragon.c
> 
> diff --git a/arch/arm/dts/dragonboard410c.dts b/arch/arm/dts/dragonboard410c.dts
> index 25aeac4..b67e588 100644
> --- a/arch/arm/dts/dragonboard410c.dts
> +++ b/arch/arm/dts/dragonboard410c.dts
> @@ -48,11 +48,6 @@
>   			clock = <&clkc 4>;
>   		};
>   
> -		restart at 4ab000 {
> -			compatible = "qcom,pshold";
> -			reg = <0x4ab000 0x4>;
> -		};
> -
>   		soc_gpios: pinctrl at 1000000 {
>   			compatible = "qcom,apq8016-pinctrl";
>   			reg = <0x1000000 0x300000>;
> diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.c b/board/qualcomm/dragonboard410c/dragonboard410c.c
> index 99fc91b..8ef4338 100644
> --- a/board/qualcomm/dragonboard410c/dragonboard410c.c
> +++ b/board/qualcomm/dragonboard410c/dragonboard410c.c
> @@ -171,3 +171,8 @@ int ft_board_setup(void *blob, bd_t *bd)
>   
>   	return 0;
>   }
> +
> +void reset_cpu(ulong addr)
> +{
> +	psci_system_reset();
> +}

I think you don't need to implement this boilerplate reset_cpu() function
if you just enable CONFIG_SYSRESET_PSCI. At least that works for qemu_arm.


More information about the U-Boot mailing list