[U-Boot] [PATCH] Makefile: ensure DTB doesn't overflow into initial stack
Stephen Warren
swarren at wwwdotorg.org
Wed Jan 10 23:20:07 UTC 2018
On 01/10/2018 02:56 PM, Tom Warren wrote:
> Stephen Warren wrote at Tuesday, January 9, 2018 12:52 PM:
> > With CONFIG_SYS_INIT_SP_BSS_OFFSET enabled, the initial (pre-relocation)
> > stack is placed some distance after bss_start. The control DTB is
> > appended to the U-Boot binary at bss_start. If the DTB is too large, or
> > the SP BSS offset too small, then the initial stack could corrupt the
> > DTB. Enhance the Makefile to check whether this is likely to occur.
> >
> > Signed-off-by: Stephen Warren <swarren at nvidia.com> --- This builds on
> > top of my previous patch "ARMv8: Allow dynamic early stack pointer".
> > However, since all the logic is conditional and only activated if
> > CONFIG_SYS_INIT_SP_BSS_OFFSET is defined, it can be applied with or
> > without that other patch. It'd make sense to apply it afterwards and in
> > the same branch though, or the change won't make a lot of sense to
> > someone reading history in order.
>
> I've got this in my TOT u-boot-tegra/master, ready to send a PR to TomR.
> But it's delegated to him in Patchwork. Do you want me to remove it
> from my PR, or leave it in?
From my perspective, either way is fine. Since you've already applied
it, you may as well include it in your pull request.
More information about the U-Boot
mailing list