[U-Boot] [PATCH] armv8: ls1088aqds: Add IFC-NOR as boot source for LS1088

[York Sun]

On 01/11/2018 01:26 AM, Ashish Kumar wrote:
> 
> 
>> -----Original Message-----
>> From: York Sun
>> Sent: Monday, January 08, 2018 11:11 PM
>> To: Ashish Kumar <ashish.kumar at nxp.com>; u-boot at lists.denx.de
>> Subject: Re: [PATCH] armv8: ls1088aqds: Add IFC-NOR as boot source for
>> LS1088
>>
>> On 01/01/2018 09:24 PM, Ashish Kumar wrote:
>>> IFC-NOR and QSPI-NOR pins are muxed on SoC,so they cannot be accessed
>>> simultaneously, but IFC-NOR can be accessed along with SD-BOOT.
>>>
>>> ls1088aqds_sdcard_ifc_defconfig: is defconfig for SD as boot source
>>> and IFC-NOR to be used as flash, this will be used to write IFC-NOR
>>> image on IFC flash.
>>> QSPI and DSPI cannot be accessed in this defconfig.
>>>
>>> IFC-NOR image is generated by ls1088aqds_defconfig.
>>>
>>> Signed-off-by: Ashish Kumar <Ashish.Kumar at nxp.com>
>>> ---
>>> depends on:
>>>
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
>>>
>> chwork.ozlabs.org%2Fpatch%2F853615%2F&data=02%7C01%7Cyork.sun%40
>> nxp.co
>>>
>> m%7Cc53b3ec4db4d48e5130a08d551a1253d%7C686ea1d3bc2b4c6fa92cd99
>> c5c30163
>>>
>> 5%7C0%7C0%7C636504674905515652&sdata=j2VD3l2%2BIb7iYk8yvn3TOrvT
>> 38pPT8A
>>> RRQjN0h%2FR5b0%3D&reserved=0
>>>
>>> Tested on 2018.01-rc3
>>>
>>> More accurate timing are used which where provided by validation team
>>>
>>> to switch to IFC-NOR use command for qspi prompt:
>>> i2c mw 66 0x60 0x12; i2c mw 66 50 00;i2c mw 66 10 21
>>
>> Can you expand qixis command to do this? You should stop using i2c
>> command to switch any banks.
> 
> Will that be ok to send separate patch with expansion of qixis commands ?

Yes, a patch before this one. I prefer not to use i2c command at all for
bank switching. If you have any comment/document showing i2c command to
do similar thing, please also clean up.

> 
>> Please add instructions to board README file to describe the flash map, and
>> the qixis commands to switch between QSPI banks, and other booting
>> sources.
> 
> Flash map is now identical for all arm64 platform(ls2088,ls2085,ls1043,ls1046 and ls1088), do I still to add the flash map?

No, if identical. But please add the base addresses information.

York