[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

Maxime Ripard maxime.ripard at free-electrons.com
Fri Jan 12 09:00:51 UTC 2018


On Thu, Jan 11, 2018 at 01:41:41PM -0500, Tom Rini wrote:
> On Thu, Jan 11, 2018 at 11:24:28PM +0530, Jagan Teki wrote:
> > On Thu, Dec 21, 2017 at 6:10 PM, Maxime Ripard
> > <maxime.ripard at free-electrons.com> wrote:
> > > The sunXi arm64 build has overflown, leading to the main U-boot binary
> > > overwriting the environment when flashing the new image, or even worse,
> > > overwriting itself when we're calling saveenv.
> > >
> > > Disable this command that is not critical until we can adress the issue
> > > properly.
> > >
> > > Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> > > ---
> > >  cmd/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > > index c0332235261f..7751001819d0 100644
> > > --- a/cmd/Kconfig
> > > +++ b/cmd/Kconfig
> > > @@ -397,6 +397,7 @@ menu "Memory commands"
> > >  config CMD_CRC32
> > >         bool "crc32"
> > >         select HASH
> > > +       default n if ARCH_SUNXI
> > >         default y
> > >         help
> > >           Compute CRC32.
> > 
> > this make unselect HASH so, few of the boards have build issues, we
> > can select sunxi directly on HASH kconfig.
> 
> OK, hold on.  This series was supposed to be pulled in to v2018.01, to
> fix size issues, before we could take the env series that I said can
> come in for v2018.03, yes?  So we should just not do this series and
> take Maxime's update to the env series which I expect to be posted soon
> so I can merge it, and sunxi can move to env in FAT and not have the
> problem it has on aarch64 atm.

They are a bit orthogonal actually.

This serie addresses the build failures we have today in order to
still be able to build binaries that work.

The FAT transition is more of a longer-term goal in order to not have
the size restriction we have eventually (hopefully 2018.05).

So the first one mitigates the problem, while the second one allows us
to get rid of the problem entirely in the future.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180112/59716b2b/attachment.sig>


More information about the U-Boot mailing list