[U-Boot] X86 Broadwell-DE override FSP configuration

[Bin Meng]

+ML

Hi Vincenzo,

On Tue, Jan 16, 2018 at 8:21 PM, vnktux <vnktux at protonmail.com> wrote:
> Hi all,
>
> I managed to fully boot a bare metal U-Boot on the Intel Camelback Mountain
> CRB (Broadwell-DE).
>

This is great!

> However I have a small problem, basically U-Boot does not override the FSP
> UPD data when the platform boot.

U-Boot can override the FSP UPD data.

> For prototyping I am using a patched FSP binary I got in the company where I
> work. Now that it boot on the camelback mountain I need it to run on another
> platform (also broadwell-de) that has memory down installed on the
> motherboard. That should be easy, all I have to do is to enable memory down
> in the fsp_config.c file and provide the address of the SPD binary file. I
> have done that, but for some reason it doesn't work. During the booting
> process the platform give an error about the Dimm module not being
> supported. That make sense since the pached FSP binary I am using has memory
> down disabled. The part I don't understand is why U-Boot doesnt override the
> UPD settings specified in my fsp_config.c file.
>
> Below you will find my implementation, can somebody explain me what am I
> doing wrong?
>
> https://raw.githubusercontent.com/WarOfDevil/u-boot.x86_64-broadwell-de/master/arch/x86/cpu/broadwell-de/fsp_configs.c
>
> https://raw.githubusercontent.com/WarOfDevil/u-boot.x86_64-broadwell-de/master/arch/x86/dts/poseidon.dts

It looks you have commented out the FSP node in the device tree, then
your fsp_configs.c won't do the UPD override.

>
> Once I manage to make this work, I can create a patch for U-Boot.
>

Regards,
Bin