[U-Boot] [U-Boot, v6, 2/2] common: Generic firmware loader for file system

[Tom Rini]

On Tue, Jan 16, 2018 at 07:58:00AM +0000, Chee, Tien Fong wrote:
> On Mon, 2018-01-15 at 11:36 -0500, Tom Rini wrote:
> > On Wed, Dec 27, 2017 at 01:04:38PM +0800, tien.fong.chee at intel.com
> > wrote:
> > 
> > > 
> > > From: Tien Fong Chee <tien.fong.chee at intel.com>
> > > 
> > > This is file system generic loader which can be used to load
> > > the file image from the storage into target such as memory.
> > > The consumer driver would then use this loader to program whatever,
> > > ie. the FPGA device.
> > > 
> > > Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>
> > Please add Lothar's Reviewed-by for v7.  There's a number of minor
> > checkpatch.pl issues that checkpatch.pl can in turn fixup itself,
> > please
> > correct them.
> > 
> I have ran the checkpatch.pl on this patch, i didn't see any error.

When I ran it, it was pointing out cases where you have:
if (foo->bar != NULL)
when you can just use:
if (foo->bar)

[snip]
> > > diff --git a/common/fs_loader.c b/common/fs_loader.c
> > > new file mode 100644
> > > index 0000000..56d29b6
> > > --- /dev/null
> > > +++ b/common/fs_loader.c
> > > @@ -0,0 +1,309 @@
> > > +/*
> > > + * Copyright (C) 2017 Intel Corporation <www.intel.com>
> > > + *
> > > + * SPDX-License-Identifier:    GPL-2.0
> > > + */
> > > +
> > > +#include <common.h>
> > > +#include <errno.h>
> > > +#include <fs.h>
> > > +#include <fs_loader.h>
> > > +#include <nand.h>
> > > +#include <sata.h>
> > > +#include <spi.h>
> > > +#include <spi_flash.h>
> > > +#include <spl.h>
> > This wants <asm/spl.h> which is not globally available, so you need
> > to
> > come up with something here.  At least making this Kconfig-enabled
> > will
> > be a start and perhaps OK for now.
> > 
> I can enable the Kconfig, and put the caution about dependency on
> <asm/spl.h> in document.

Well, you need to make that part of the code depend on CONFIG_SPL as SPL
support requires <asm/spl.h> to exist.   Perhaps part of the code needs
to be refactored to more easily deal with SPL not always being present?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180116/bde7fd01/attachment.sig>