[U-Boot] [PATCH 6/7] libfdt: migrate libfdt.h to a wrapper

Masahiro Yamada yamada.masahiro at socionext.com
Tue Jan 16 15:41:00 UTC 2018


2018-01-16 23:56 GMT+09:00 Simon Glass <sjg at chromium.org>:
> On 9 January 2018 at 01:34, Masahiro Yamada
> <yamada.masahiro at socionext.com> wrote:
>> Remove the tons of code duplication between include/libfdt.h and
>> sciprts/dtc/libfdt/libfdt.h.  I am keeping U-Boot local code in
>> include/libfdt.h.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>> ---
>>
>>  include/libfdt.h | 1856 +-----------------------------------------------------
>>  1 file changed, 8 insertions(+), 1848 deletions(-)
>
> Didn't you just add this file two patches ago? Why not just not add it?
>

Well, a good question.

I tried to do one thing in each commit.

Two patches ago, I moved 2100 lines to this file.
Then, I deleted 1800 lines in this patch.

If I had merged them into one patch, I would have just needed
to move 300 lines.


I will take a look if you do not want to see the huge diffs twice.


-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list