[U-Boot] [PATCH] tools: Update python "help" tests to cope with "more" oddities

Simon Glass sjg at chromium.org
Tue Jan 16 21:12:14 UTC 2018


On 16 January 2018 at 12:29, Tom Rini <trini at konsulko.com> wrote:
> In some cases when "more" is told to page a given file it will prepend
> the output with:
> ::::::::::::::
> /PATH/TO/THE/FILE
> ::::::::::::::
>
> And when this happens the output will not match the expected length.
> Further, if we use a different pager we will instead fail the coverage
> tests as we will not have 100% coverage.  Update the help test to remove
> the string in question.
>
> Cc: Simon Glass <sjg at chromium.org>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> I see this behavior when running the tests via Jenkins in my container,
> but not when run manually in my container.  As implied above, I tried
> switching to less via the env, which causes these tests to pass but then
> the coverage tests fail as we will not have coverage of the line about
> "if not pager" and thus not have 100% coverage.
> ---
>  tools/binman/ftest.py       | 5 ++++-
>  tools/buildman/func_test.py | 5 ++++-
>  2 files changed, 8 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list