[U-Boot] [PATCH v2] ubi: Ensure no fastmap flush after uif_close

Martin Townsend mtownsend1973 at gmail.com
Thu Jan 18 08:07:33 UTC 2018


On detach UBI attempts to update fastmap after closing user interfaces
but at this point UBI volumes have already been free()'ed and fastmap
can no longer access these data structures.

Signed-off-by: Martin Townsend <mtownsend1973 at gmail.com>
Cc: hs at denx.de
Cc: kmpark at infradead.org
Cc: richard at sigma-star.at
---
Changes for v2:
   - Fix by removing update to fastmap from ubi_fastmap_close instead
     of reordering uif_close and ubi_wl_close in ubi_detach_mtd_dev

 drivers/mtd/ubi/fastmap-wl.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/mtd/ubi/fastmap-wl.c b/drivers/mtd/ubi/fastmap-wl.c
index a33d406..b7876a8 100644
--- a/drivers/mtd/ubi/fastmap-wl.c
+++ b/drivers/mtd/ubi/fastmap-wl.c
@@ -337,11 +337,6 @@ static void ubi_fastmap_close(struct ubi_device *ubi)
 {
 	int i;
 
-#ifndef __UBOOT__
-	flush_work(&ubi->fm_work);
-#else
-	update_fastmap_work_fn(ubi);
-#endif
 	return_unused_pool_pebs(ubi, &ubi->fm_pool);
 	return_unused_pool_pebs(ubi, &ubi->fm_wl_pool);
 
-- 
2.7.4



More information about the U-Boot mailing list