[U-Boot] [PATCH V5 26/31] net: fec: do not access reserved register for i.MX8M

Stefano Babic sbabic at denx.de
Sun Jan 21 16:34:20 UTC 2018



On 10/01/2018 06:20, Peng Fan wrote:
> The MIB RAM and FIFO receive start register does not exist on
> i.MX8M. Accessing these register will cause system hang.
> 
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
> Reviewed-by: Stefano Babic <sbabic at denx.de>
> Reviewed-by: Fabio Estevam <fabio.estevam at nxp.com>
> ---
>  drivers/net/fec_mxc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index 433e19f0f8..4cbc8cbbfd 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -562,8 +562,8 @@ static int fec_init(struct eth_device *dev, bd_t *bd)
>  	writel(0x00000000, &fec->eth->gaddr1);
>  	writel(0x00000000, &fec->eth->gaddr2);
>  
> -	/* Do not access reserved register for i.MX6UL */
> -	if (!is_mx6ul() && !is_mx6ull()) {
> +	/* Do not access reserved register */
> +	if (!is_mx6ul() && !is_mx6ull() && !is_mx8m()) {
>  		/* clear MIB RAM */
>  		for (i = mib_ptr; i <= mib_ptr + 0xfc; i += 4)
>  			writel(0, i);
> 

Reviewed-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic
-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list