[U-Boot] [PATCH 1/2] sunxi: fix i2c support for sunxi H3/H5

[Maxime Ripard]

On Fri, Jan 19, 2018 at 09:35:58PM +0100, Jernej Škrabec wrote:
> Hi,
> 
> Dne petek, 19. januar 2018 ob 19:38:52 CET je Nuno Gonçalves napisal(a):
> > Sorry, there is only 1 patch in this series.
> > 
> > I would like comments regarding removing DM_I2C for MACH_SUNXI_H3_H5,
> > as I didn't found a reason for it to be defined.
> 
> there is good reason to be there. When H3/H5 board has DE2/HDMI enabled, 
> warning is shown when configuring, if DM_I2C is not selected. Since there 
> should be no warning, DM_I2C has to stay.
> 
> This means that whatever you want to have attached to I2C, you have to have an 
> entry in DT for it. Since there is no DM pinctrl driver, you have to put code 
> somewhere, like you already done.
> 
> Besides, U-Boot wants to migrate towards DM drivers, no other way
> around. Last time I checked, DM I2C driver for H3/H5 should work,
> although it wasn't thoroughly tested from my side. So if there are
> issues with DM I2C driver, you have to fix it.

I should have looked closer, yes, you should keep the select on DM_I2C
here.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180122/39b3db04/attachment.sig>