[U-Boot] [PATCH v2] arm: add support for PDU001

Felix Brack fb at ltec.ch
Mon Jan 22 16:33:59 UTC 2018


Hi Tom,

On 22.01.2018 16:15, Tom Rini wrote:
> On Mon, Jan 22, 2018 at 12:07:49PM +0100, Felix Brack wrote:
> 
>> This patch adds support for the PDU001 board.
>>
>> Signed-off-by: Felix Brack <fb at ltec.ch>
> [snip]
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index f6d57f5..15349b3 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1339,6 +1339,7 @@ source "board/vscom/baltos/Kconfig"
>>  source "board/woodburn/Kconfig"
>>  source "board/work-microwave/work_92105/Kconfig"
>>  source "board/zipitz2/Kconfig"
>> +source "board/eets/pdu001/Kconfig"
> 
Sorry, missed that one.

> This should stay alphabetized.
> 
> [snip]
>> new file mode 100644
>> index 0000000..0967e82
>> --- /dev/null
>> +++ b/arch/arm/dts/am335x-pdu001.dts
>
> So, have you pushed this platform upstream to Linux?
> 
Not yet. I would like to follow the same procedure for Linux as I did
for U-Boot, i.e. first finish the work on all drivers required by the board.

>> @@ -0,0 +1,612 @@
>> +/*
>> + * pdu001.dts
>> + *
>> + * EETS GmbH PDU001 board device tree file
>> + *
>> + * Copyright (C) 2018 EETS GmbH - http://www.eets.ch/
>> + *
>> + * Copyright (C) 2011, Texas Instruments, Incorporated - http://www.ti.com/
>> + *
>> + * SPDX-License-Identifier:  GPL-2.0-or-later
> 
> This is not a free-form tag.  Here and elsewhere you want "GPL-2.0+".
>
Well, I followed the advice on https://spdx.org/licenses/ when using
this tag. According to SPDX "GPL-2.0+" is deprecated as of V2.0rc2 and
the use of "GPL-2.0-or-later" is suggested instead. However I'm fine
using "GPL-2.0+", just let me know.

> [snip]
>> +	ocp {
>> +		u-boot,dm-pre-reloc;
>> +	};
>> +};
>> +
>> +&l4_wkup {
>> +	u-boot,dm-pre-reloc;
>> +};
>> +
>> +&scm {
>> +	u-boot,dm-pre-reloc;
>> +};
>> +
> 
> For long term maintenance you'll want to move these U-Boot specific
> parts to a am335x-pdu001-u-boot.dtsi file so that you can re-sync the
> main DTS file with Linux and not have any important U-Boot changes be
> dropped.
>
Thanks for the hint!

regards, Felix


More information about the U-Boot mailing list