[U-Boot] [PATCH] cmd: Kconfig: Make CMD_NAND select NAND

[Andrew F. Davis]

On 01/23/2018 12:01 PM, Adam Ford wrote:
> On Tue, Jan 23, 2018 at 11:15 AM, Andrew F. Davis <afd at ti.com> wrote:
>> On 01/23/2018 04:40 AM, Adam Ford wrote:
>>> Many boards check for CONFIG_CMD_NAND instead of CONFIG_NAND, so
>>> let's make CMD_NAND select NAND to make some Kconfig migration
>>> easier
>>>
>>> Signed-off-by: Adam Ford <aford173 at gmail.com>
>>>
>>> diff --git a/cmd/Kconfig b/cmd/Kconfig
>>> index 35fe9d5..9f6b351 100644
>>> --- a/cmd/Kconfig
>>> +++ b/cmd/Kconfig
>>> @@ -764,6 +764,7 @@ config CMD_MMC
>>>  config CMD_NAND
>>>       bool "nand"
>>>       default y if NAND_SUNXI
>>> +     select NAND
>>
>> Should be depends on
> 
> On the surface, I would agree with you, but many boards are looking
> for CONFIG_CMD_NAND and not looking for (or dependant on) CONFIG_NAND
> to set their NAND parameters. I was hoping to do some NAND parameter
> migration and I was going to make those parameters dependent on
> CONFIG_NAND by setting CONFIG_NAND from CMD_NAND, it makes this
> migration a lot smoother.  Otherwise, I have to go through a bunch of
> configs and enable CONFIG_NAND in each one.
> 


Well as long as it helps the migration and can/will be fixed up after, I
don't object.


> adam
>>
>>>       help
>>>         NAND support.
>>>
>>>