[U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

[Benoît Thébaudeau]

Hi Fabio,

On 24/01/2018 at 18:21, Fabio Estevam wrote:
> On Wed, Jan 24, 2018 at 3:12 PM, Michael Nazzareno Trimarchi
> <michael at amarulasolutions.com> wrote:
> 
>> From the datasheet I have:
>>
>> Software Input On Field. Force the selected mux mode Input path no
>> matter of MUX_MODE functionality.
>> 1: Force input path of pad A14.
>> 0: Input Path is determined by functionality of the selected mux mode
>> (regular).
>>
>> So i think that in case of some peripheral this is not relevant but I
>> need confirmation
> 
> Looking at arch/arm/boot/dts/imx25-pinfunc.h I see that there is only
> one pin that sets the SION bit in the common pin definition:
> 
> /*
>  * Removing the SION bit from MX25_PAD_SD1_CMD__SD1_CMD breaks detecting an SD
>  * card. According to the i.MX25 reference manual (e.g. Figure 23-2 in IMX25RM
>  * Rev. 2 from 01/2011) this pin is bidirectional. So it seems to be a silicon
>  * bug that configuring the SD1_CMD function doesn't enable the input path for
>  * this pin.
>  * This might have side effects for other hardware units that are connected to
>  * that pin and use the respective function as input.
>  */
> #define MX25_PAD_SD1_CMD__SD1_CMD        0x190 0x388 0x000 0x10 0x000

In mainline Linux, SION is also set by some DTS files (MX25_PAD_* 0x40000000
flag) for FEC MDIO and SD CMD/CLK/DATAn.

Best regards,
Benoît