[U-Boot] [PATCH 2/8] spl: nand: sunxi: Fix second case of modulo by zero error

Miquel Raynal miquel.raynal at free-electrons.com
Wed Jan 24 22:32:34 UTC 2018


Hi Maxime,

On Wed, 24 Jan 2018 08:47:31 +0100
Maxime Ripard <maxime.ripard at free-electrons.com> wrote:

> On Wed, Jan 24, 2018 at 01:44:48AM +0100, Miquel Raynal wrote:
> > In the nand_read_buffer() step, the seed is calculated by doing a modulo
> > by conf->nseeds which is always zero when not using the randomizer (most
> > of SLC NANDs).
> > 
> > This situation turns out to lead to a run time freeze.
> > 
> > Derive this seed only when the randomizer is enabled (and conf->nseeds
> > logically not zero).  
> 
> Mentionning the first occurence of that issue in your commit log would
> be great, especially since the situation depends on configuration
> options.

Absolutely, I added a reference in the commit message to:
ea3f750c73e3 ("nand: sunxi: Fix modulo by zero error")

Thanks,
Miquèl


More information about the U-Boot mailing list