[U-Boot] [PATCH 1/7] mmc: uniphier-sd: Use mmc_of_parse()

Jaehoon Chung jh80.chung at samsung.com
Thu Jan 25 01:01:11 UTC 2018


Hi,

On 01/17/2018 02:16 AM, Marek Vasut wrote:
> Drop the ad-hoc DT caps parsing in favor of common framework function.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
> Cc: Jaehoon Chung <jh80.chung at samsung.com>
> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>

If Masahiro is ok, i will pick this patch and others to u-boot-mmc.

Best Regards,
Jaehoon Chung

> ---
>  drivers/mmc/uniphier-sd.c | 23 +++++++----------------
>  1 file changed, 7 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/mmc/uniphier-sd.c b/drivers/mmc/uniphier-sd.c
> index 741f9dfd9c..552e37d852 100644
> --- a/drivers/mmc/uniphier-sd.c
> +++ b/drivers/mmc/uniphier-sd.c
> @@ -799,24 +799,15 @@ static int uniphier_sd_probe(struct udevice *dev)
>  		return ret;
>  	}
>  
> -	plat->cfg.name = dev->name;
> -	plat->cfg.host_caps = MMC_MODE_HS_52MHz | MMC_MODE_HS;
> -
> -	switch (fdtdec_get_int(gd->fdt_blob, dev_of_offset(dev), "bus-width",
> -			       1)) {
> -	case 8:
> -		plat->cfg.host_caps |= MMC_MODE_8BIT;
> -		break;
> -	case 4:
> -		plat->cfg.host_caps |= MMC_MODE_4BIT;
> -		break;
> -	case 1:
> -		break;
> -	default:
> -		dev_err(dev, "Invalid \"bus-width\" value\n");
> -		return -EINVAL;
> +	ret = mmc_of_parse(dev, &plat->cfg);
> +	if (ret < 0) {
> +		dev_err(dev, "failed to parse host caps\n");
> +		return ret;
>  	}
>  
> +	plat->cfg.name = dev->name;
> +	plat->cfg.host_caps |= MMC_MODE_HS_52MHz | MMC_MODE_HS;
> +
>  	if (quirks) {
>  		priv->caps = quirks;
>  	} else {
> 



More information about the U-Boot mailing list