[U-Boot] [PATCH] mmc: uniphier-sd: Add compatible strings for RCar Gen2

Marek Vasut marek.vasut at gmail.com
Thu Jan 25 11:15:16 UTC 2018


On 01/25/2018 11:22 AM, Masahiro Yamada wrote:
> 2018-01-25 9:58 GMT+09:00 Jaehoon Chung <jh80.chung at samsung.com>:
>> On 01/25/2018 07:19 AM, Marek Vasut wrote:
>>> Add DT compatible strings for RCar Gen2 SoCs, so that this driver
>>> can bind with them. Unlike Gen3, which uses 64bit FIFO, the Gen2
>>> uses 16bit FIFO.
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
>>> Cc: Jaehoon Chung <jh80.chung at samsung.com>
>>> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
>>
>> Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>
>>
>>> ---
>>>  drivers/mmc/uniphier-sd.c | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/mmc/uniphier-sd.c b/drivers/mmc/uniphier-sd.c
>>> index 741f9dfd9c..a080674c8a 100644
>>> --- a/drivers/mmc/uniphier-sd.c
>>> +++ b/drivers/mmc/uniphier-sd.c
>>> @@ -847,6 +847,11 @@ static int uniphier_sd_probe(struct udevice *dev)
>>>  }
>>>
>>>  static const struct udevice_id uniphier_sd_match[] = {
>>> +     { .compatible = "renesas,sdhi-r8a7790", .data = 0 },
>>> +     { .compatible = "renesas,sdhi-r8a7791", .data = 0 },
>>> +     { .compatible = "renesas,sdhi-r8a7792", .data = 0 },
>>> +     { .compatible = "renesas,sdhi-r8a7793", .data = 0 },
>>> +     { .compatible = "renesas,sdhi-r8a7794", .data = 0 },
>>>       { .compatible = "renesas,sdhi-r8a7795", .data = UNIPHIER_SD_CAP_64BIT },
>>>       { .compatible = "renesas,sdhi-r8a7796", .data = UNIPHIER_SD_CAP_64BIT },
>>>       { .compatible = "renesas,sdhi-r8a77970", .data = UNIPHIER_SD_CAP_64BIT },
>>>
>>
> 
> 
> Nit:
> You can omit ".data = 0 " if you want.
> 
> Otherwise,
> 
> Acked-by: Masahiro Yamada <yamada.masahiro at socionext.com>

I don't want to remove the data = , because I'll be adding more of those
cap flags there in the next round . In particular, the Gen2 cannot use
that internal DMA controller while Gen3 can and a few other quirks. Oh,
and support for 16bit SD controller is coming too ;-)

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list