[U-Boot] [PATCH v3 19/26] cfi_flash: Use u8 pointers instead of void pointers
Mario Six
mario.six at gdsys.cc
Fri Jan 26 13:43:49 UTC 2018
According to the C standard, pointer arithmetic for pointers of type
void is undefined behavior (the assumption that they're 8-bit wide is a
GCC-specific assumption). In the interest of keeping the code
standards-compliant, and also better communicate intent, switch all
void* variables where pointer arithmetic is used to u8* variables.
Signed-off-by: Mario Six <mario.six at gdsys.cc>
---
v2 -> v3:
* Added proper commit message
v1 -> v2:
None
---
drivers/mtd/cfi_flash.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index 48086ded5c..fced9847ef 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -491,7 +491,7 @@ static int flash_isset(flash_info_t *info, flash_sect_t sect,
static int flash_toggle(flash_info_t *info, flash_sect_t sect,
uint offset, uchar cmd)
{
- void *addr;
+ u8 *addr;
cfiword_t cword;
int retval;
@@ -872,9 +872,9 @@ static int flash_write_cfibuffer(flash_info_t *info, ulong dest, uchar *cp,
flash_sect_t sector;
int cnt;
int retcode;
- void *src = cp;
- void *dst = (void *)dest;
- void *dst2 = dst;
+ u8 *src = cp;
+ u8 *dst = (u8 *)dest;
+ u8 *dst2 = dst;
int flag = 1;
uint offset = 0;
unsigned int shift;
--
2.11.0
More information about the U-Boot
mailing list