[U-Boot] [PATCH 4/4] usb: ehci-mxs: Fix argument order for ehci_writel()

[Marek Vasut]

On 01/27/2018 08:48 PM, Tom Rini wrote:
> The order of arguments for ehci_writel() is 'dest', 'value' and not
> 'value', 'dest'.
> 
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Marek Vasut <marex at denx.de>
> Signed-off-by: Tom Rini <trini at konsulko.com>

Already fixed and in the current USB PR, see:

    usb: ehci: mxs: fix swapped argument in ehci_writel()


> ---
>  drivers/usb/host/ehci-mxs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-mxs.c b/drivers/usb/host/ehci-mxs.c
> index 6b8d969bb000..9872415562c2 100644
> --- a/drivers/usb/host/ehci-mxs.c
> +++ b/drivers/usb/host/ehci-mxs.c
> @@ -156,7 +156,7 @@ int ehci_hcd_stop(int index)
>  
>  	tmp = ehci_readl(&hcor->or_usbcmd);
>  	tmp &= ~CMD_RUN;
> -	ehci_writel(tmp, &hcor->or_usbcmd);
> +	ehci_writel(&hcor->or_usbcmd, tmp);
>  
>  	/* Disable the PHY */
>  	tmp = USBPHY_PWD_RXPWDRX | USBPHY_PWD_RXPWDDIFF |
> 


-- 
Best regards,
Marek Vasut