[U-Boot] [PATCH] net: sun8i_emac: Fix PHY initialization

Samuel Holland samuel at sholland.org
Sun Jan 28 05:53:20 UTC 2018


The previous code tried to update the PHY parameters without waiting for
autonegotiation to complete. This caused wrong values to be written to
the EMAC in sun8i_adjust_link(). As a result, any commands that called
eth_start() before autonegotiation completed would find the network
nonfunctional. Fix this by using the correct function to start up the
PHY.

Signed-off-by: Samuel Holland <samuel at sholland.org>
---
 drivers/net/sun8i_emac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
index 3ccc6b0bb6..be43472b1a 100644
--- a/drivers/net/sun8i_emac.c
+++ b/drivers/net/sun8i_emac.c
@@ -431,7 +431,7 @@ static int _sun8i_emac_eth_init(struct emac_eth_dev *priv, u8 *enetaddr)
 	tx_descs_init(priv);
 
 	/* PHY Start Up */
-	genphy_parse_link(priv->phydev);
+	phy_startup(priv->phydev);
 
 	sun8i_adjust_link(priv, priv->phydev);
 
-- 
2.13.6



More information about the U-Boot mailing list