[U-Boot] [PATCH v3 08/30] sunxi: usb_phy: Clear PHYCTL register before writing

Jagan Teki jagannadh.teki at gmail.com
Mon Jan 29 08:14:53 UTC 2018


On Mon, Jan 29, 2018 at 1:29 PM, Maxime Ripard
<maxime.ripard at free-electrons.com> wrote:
> Hi,
>
> On Sun, Jan 28, 2018 at 09:49:29PM +0530, Jagan Teki wrote:
>> PHYCTL register offset at 0x10 need to be cleared before it's
>> written. Ported from below Linux patch.
>>   d699c1d phy: sun4i-usb: change PHYCTL register clearing code
>>
>> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
>> Signed-off-by: Jun Nie <jun.nie at linaro.org>
>
> Those signed-off-by don't make much sense. Either Jun made that patch
> and should be the author, or you made that patch, and Jun Signed-off
> shouldn't be there.

Don't understand what doesn't make sense, more Signed-off-by implies
group of people worked on the particular change and author who usually
made this. This is what I usually follow all my patches if the
change/patch work together.


More information about the U-Boot mailing list