[U-Boot] [U-Boot, v3, 01/15] serial: Use next serial device if probing fails

[Alexander Graf]

On 29.01.18 04:27, Derald D. Woods wrote:
> On Sun, Jan 28, 2018 at 01:54:50PM -0500, Tom Rini wrote:
>> On Thu, Jan 25, 2018 at 12:05:42PM +0100, Alexander Graf wrote:
>>
>>> Currently our serial device search chokes on the fact that the serial
>>> probe function could fail. If it does, instead of searching for the next
>>> usable serial device, it just quits.
>>>
>>> This patch changes the fallback logic so that even when a serial device
>>> was not probed correctly, we just try the next ones until we find one that
>>> works.
>>>
>>> Signed-off-by: Alexander Graf <agraf at suse.de>
>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> Applied to u-boot/master, thanks!
>>
>> -- 
>> Tom
> 
> Is there something, at the board level, that needs to be coded to
> support this patch? The omap3_evm fails to boot with this patch applied.
> Reverting it allows omap3_evm to boot again. I am testing with the base
> default config for omap3_evm.

I've tried to reproduce the failure on a beagleboard xM, but was unable
to see it fail. Even with the beagleboard configured basically using the
same mechanisms (SPL_DM, manually defining CONFIG_SYS_NS16550_COM1, etc)
I don't see it fail with CONFIG_SERIAL_SEARCH_ALL=y.

Unfortunately I don't have an omap3 evm to test it on directly :(.

Can you maybe share a bit more of the failure details? What exactly
fails? When does it fail? I assume you're not seeing serial output? Does
it boot nevertheless, albeit without serial output?


Alex