[U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n'

Bin Meng bmeng.cn at gmail.com
Tue Jan 30 13:04:38 UTC 2018


On Tue, Jan 30, 2018 at 8:59 PM, Ulf Magnusson <ulfalizer at gmail.com> wrote:
> 'select n' selects a constant symbol, which is meaningless and has no
> effect. Maybe this was meant to be a 'default n', though bool and
> tristate symbols already implicitly default to n.
>
> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
> which does more strict checking here:
>
>         kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse '        select n': expected nonconstant symbol
>
> Signed-off-by: Ulf Magnusson <ulfalizer at gmail.com>
> ---
>  board/google/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list