[U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default

Michal Simek michal.simek at xilinx.com
Tue Jan 30 13:25:26 UTC 2018


On 30.1.2018 14:02, Ulf Magnusson wrote:
> There is no JTAG symbol in the "Boot mode" choice. JTAG_MODE was
> probably intended.
> 
> No functional changes. Kconfig choices fall back on using the first
> (visible) symbol in the choice as the default if the default symbol is
> not visible.
> 
> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
> which prints the following warning:
> 
> 	warning: the default selection JTAG (undefined) of <choice> (defined at arch/arm/cpu/armv8/zynqmp/Kconfig:107) is not contained in the choice
> 
> I've added a corresponding warning to the C tools too, which is
> currently in linux-next: https://patchwork.kernel.org/patch/9983667/
> 
> Signed-off-by: Ulf Magnusson <ulfalizer at gmail.com>
> ---
>  arch/arm/cpu/armv8/zynqmp/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/cpu/armv8/zynqmp/Kconfig b/arch/arm/cpu/armv8/zynqmp/Kconfig
> index 3f922b4097..56b7846f63 100644
> --- a/arch/arm/cpu/armv8/zynqmp/Kconfig
> +++ b/arch/arm/cpu/armv8/zynqmp/Kconfig
> @@ -107,7 +107,7 @@ config SPL_ZYNQMP_ALT_BOOTMODE
>  choice
>  	prompt "Boot mode"
>  	depends on SPL_ZYNQMP_ALT_BOOTMODE_ENABLED
> -	default JTAG
> +	default JTAG_MODE
>  
>  config JTAG_MODE
>  	bool "JTAG_MODE"
> 

Applied. How to run this tool inside u-boot?

Thanks,
Michal


More information about the U-Boot mailing list