[U-Boot] [PATCH] env: sf: fix return value of env_sf_load

Tom Rini trini at konsulko.com
Tue Jan 30 15:23:19 UTC 2018


On Tue, Jan 30, 2018 at 09:15:09AM +0100, Simon Goldschmidt wrote:
> On 30.01.2018 08:55, Simon Goldschmidt wrote:
> >With the recent changes to support multiple environments, I see a
> >message "Failed (1)" when loading environment from sf.
> >
> >env_sf_load() returns the return value of env_import(). This must be
> >'inverted' to return the correct meaning.
> 
> Thinking about this again, it might be cleaner to make env_import and
> env_import_redundant return 0 on success. Would that be acceptable?

If it makes things look cleaner, yes, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180130/0a6b0b62/attachment.sig>


More information about the U-Boot mailing list