[U-Boot] [PATCH 03/16] common: add a prototype for mach_cpu_init()

Simon Glass sjg at chromium.org
Tue Mar 6 17:51:14 UTC 2018


Hi Patrick,

On 5 March 2018 at 07:24, Patrick Delaunay <patrick.delaunay at st.com> wrote:
>
> avoid warning: no previous prototype for ‘mach_cpu_init’
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> ---
>
>  include/common.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/include/common.h b/include/common.h
> index 0fe9439..5b6f788 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -474,6 +474,16 @@ int        is_core_valid (unsigned int);
>   */
>  int arch_cpu_init(void);
>
> +/**
> + * mach_cpu_init() - SoC/machine dependent CPU setup
> + *
> + * This is called after arch_cpu_init(). It should handle any
> + * SoC or machine specific init needed to continue the init sequence. See
> + * board_f.c for where it is called. If this is not provided, a default
> + * version (which does nothing) will be used.

Great, but can you please add @return docs?

> + */
> +int mach_cpu_init(void);
> +
>  void s_init(void);
>
>  int    checkcpu      (void);
> --
> 2.7.4
>

Regards,
Simon


More information about the U-Boot mailing list