[U-Boot] [PATCH 03/16] common: add a prototype for mach_cpu_init()

Patrick DELAUNAY patrick.delaunay at st.com
Wed Mar 7 14:26:50 UTC 2018


Hi Simon

> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> 
> Hi Patrick,
> 
> On 5 March 2018 at 07:24, Patrick Delaunay <patrick.delaunay at st.com> wrote:
> >
> > avoid warning: no previous prototype for ‘mach_cpu_init’

> > +/**
> > + * mach_cpu_init() - SoC/machine dependent CPU setup
> > + *
> > + * This is called after arch_cpu_init(). It should handle any
> > + * SoC or machine specific init needed to continue the init sequence.
> > +See
> > + * board_f.c for where it is called. If this is not provided, a
> > +default
> > + * version (which does nothing) will be used.
> 
> Great, but can you please add @return docs?

Yes, I will do it
@return: 0 on success, otherwise error

I will also add the same for arch_cpu_init() in the same patch...

but after check, the warning is no more present in the v1 Serie after rework before push,
because mach_stm32mp don't use mach_cpu_init() but arch_cpu_init().

So this patch is not more required for my stm32mp arch (and I will remove it in V2 serie)

But I will sent today just this patch in v2 (without Serie).

> 
> Regards,
> Simon

Regards
Patrick


More information about the U-Boot mailing list