[U-Boot] [PATCH v3 02/10] video: add support of MIPI DSI interface

[Simon Glass]

Hi,

On 13 March 2018 at 07:50, yannick fertre <yannick.fertre at st.com> wrote:
>
> Mipi_display.c contains a set of dsi helpers.
> This file is a copy of file drm_mipi_dsi.c (linux kernel).
>
> Signed-off-by: yannick fertre <yannick.fertre at st.com>
> ---
>  drivers/video/Kconfig        |   7 +
>  drivers/video/Makefile       |   1 +
>  drivers/video/mipi_display.c | 807 +++++++++++++++++++++++++++++++++++++++++++
>  include/mipi_display.h       | 257 +++++++++++++-

Please add function comments for the functions in this file,
explaining args and what the functions do.

Shouldn't DSI be its own uclass? We normally separate drivers for
different peripherals in U-Boot.

>  4 files changed, 1071 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/video/mipi_display.c
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 2fc0def..1981298 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -75,6 +75,13 @@ config VIDEO_ANSI
>           Enable ANSI escape sequence decoding for a more fully functional
>           console.
>
> +config VIDEO_MIPI_DSI
> +       bool "Support MIPI DSI interface"
> +       depends on DM_VIDEO
> +       default y if DM_VIDEO
> +       help
> +         Support MIPI DSI interface for driving a MIPI compatible LCD panel.

Please expand out what MIPI stands for and what it is, same with DSI.